feat: Add command for running glaredb locally #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1008 Help: ``` Starts a local version of GlareDB Usage: glaredb local [OPTIONS] Options: -m, --metastore-addr <METASTORE_ADDR> Address to the Metastore. If not provided, an in-process metastore will be started. --spill-path <SPILL_PATH> Path to spill temporary files to -f, --local-file-path <LOCAL_FILE_PATH> Local file path to store database catalog (for a local persistent store) -h, --help Print help (see a summary with '-h') ``` Running: ``` Running `target/debug/glaredb local` GlareDB (0.0.8) > select 1; +----------+ | Int64(1) | +----------+ | 1 | +----------+ > select 1; select 2; +----------+ | Int64(1) | +----------+ | 1 | +----------+ +----------+ | Int64(2) | +----------+ | 2 | +----------+ > select what from where; ERROR: Error during planning: Context provider for SQL planner is missing a table: where > interrupt: 2 ```
vrongmeal
reviewed
May 23, 2023
crates/glaredb/src/local.rs
Outdated
Comment on lines
59
to
64
| Err(ReadlineError::Interrupted) => { | ||
| break; | ||
| } | ||
| Err(ReadlineError::Eof) => { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Suggested change
| Err(ReadlineError::Interrupted) => { | |
| break; | |
| } | |
| Err(ReadlineError::Eof) => { | |
| break; | |
| } | |
| Err(ReadlineError::Interrupted) | Err(ReadlineError::Eof) => { | |
| break; | |
| } |
vrongmeal
reviewed
May 23, 2023
crates/glaredb/src/local.rs
Outdated
Comment on lines
119
to
120
| ExecutionResult::Query { stream, .. } => print_stream(stream).await?, | ||
| ExecutionResult::ShowVariable { stream } => print_stream(stream).await?, |
There was a problem hiding this comment.
Suggested change
| ExecutionResult::Query { stream, .. } => print_stream(stream).await?, | |
| ExecutionResult::ShowVariable { stream } => print_stream(stream).await?, | |
| ExecutionResult::Query { stream, .. } | ExecutionResult::ShowVariable { stream } => print_stream(stream).await?, |
vrongmeal
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008
Help:
Running: